-
Notifications
You must be signed in to change notification settings - Fork 1.8k
add arrow_typeof #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add arrow_typeof #3120
Conversation
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome and very helpful @waitingkuo 👍
| #[tokio::test] | ||
| async fn arrow_typeof_null() -> Result<()> { | ||
| let ctx = SessionContext::new(); | ||
| let sql = "SELECT arrow_typeof(true)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test is named 'typeof_nullbut this seems to test aarrow_typeof(true)rather thanarrow_typeof(null)`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thank you.
Codecov Report
@@ Coverage Diff @@
## master #3120 +/- ##
==========================================
+ Coverage 85.93% 85.95% +0.02%
==========================================
Files 290 291 +1
Lines 52295 52382 +87
==========================================
+ Hits 44939 45025 +86
- Misses 7356 7357 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks again @waitingkuo ❤️ |
|
Benchmark runs are scheduled for baseline = c525e6c and contender = 9e0bc50. 9e0bc50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3095
Rationale for this change
allow us to use arrow_typeof to check the datatype
e.g.
What changes are included in this PR?
Are there any user-facing changes?