MINOR: Add bounds check to Column physical expression #3238
Conversation
|
|
||
| /// Get the data type of this expression, given the schema of the input | ||
| fn data_type(&self, input_schema: &Schema) -> Result<DataType> { | ||
| self.bounds_check(input_schema)?; |
There was a problem hiding this comment.
Can we move the bound check into the constructor?
There was a problem hiding this comment.
No. We can only do the bounds check when the input schema is available, during evaluation.
|
Benchmark runs are scheduled for baseline = c11f303 and contender = bdc56ca. bdc56ca is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
3 participants
Which issue does this PR close?
N/A
Rationale for this change
Make it easier to debug internal errors
What changes are included in this PR?
Add bounds check and return a nice error message.
Are there any user-facing changes?
Better errors