-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Expr variants for boolean operations
#3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @sarahyurick this looks good so far. I created a PR against your branch to fix the protobuf part. https://github.com/sarahyurick/arrow-datafusion/pull/1/files |
protobuf support
|
Awesome, thanks! |
|
The final piece here is to update the SQL query planner (datafusion/sql/src/planner.rs) so that we map the SQL expressions to these new Logical Plan expressions instead of to |
|
Actually, one other thing will be to map these new Operator::IsDistinctFrom => {
match (left_data_type, right_data_type) {
// exchange lhs and rhs when lhs is Null, since `binary_array_op` is
// always try to down cast array according to $LEFT expression.
(DataType::Null, _) => {
binary_array_op!(right, left, is_distinct_from)
}
_ => binary_array_op!(left, right, is_distinct_from),
}
} |
|
On second thoughts, let's handle the physical plan side of this as a follow on PR. I filed #3288 to track this. |
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sarahyurick. Let's go ahead and merge this and then we can follow up with integrating with the SQL query planner and the physical plan.
|
Benchmark runs are scheduled for baseline = fb2f0db and contender = a32c408. a32c408 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3268
Rationale for this change
Hi @andygrove, let me know if this is what you were thinking.