-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix SchemaError in FilterPushDown optimization with UNION ALL #3282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3282 +/- ##
==========================================
+ Coverage 85.74% 85.81% +0.07%
==========================================
Files 294 294
Lines 53770 53775 +5
==========================================
+ Hits 46104 46148 +44
+ Misses 7666 7627 -39
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great -- thank you @jonmmease
I apologize for the late review. 🙏
|
Benchmark runs are scheduled for baseline = 7a53872 and contender = e3f412c. e3f412c is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…#3282) * Add failing union_all_on_projection test * Update projection step to replace both qualified and unqualified columns * Remove redundant clone
Which issue does this PR close?
Closes #3281
Rationale for this change
Fix
SchemaErrorWhat changes are included in this PR?
This change here was initially proposed in #1781, but was removed during review since there wasn't a known situation (or test) that required it. The new test,
union_all_on_projection, fails without this change.Are there any user-facing changes?
No