Remove panics from common_subexpr_eliminate

[andygrove]

Which issue does this PR close?

Part of #3314

Rationale for this change

Optimizer can recover from rules that fail with Err but not if they panic

What changes are included in this PR?

Remove panics

Are there any user-facing changes?

No

[andygrove]

@avantgardnerio this is the last of these today and collectively they remove all panics from optimizer rules AFAIK

[avantgardnerio]

👍

[codecov-commenter]

Codecov Report

Merging #3346 (8d3e127) into master (dadd2dc) will decrease coverage by 0.35%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master    #3346      +/-   ##
==========================================
- Coverage   85.83%   85.48%   -0.36%     
==========================================
  Files         294      294              
  Lines       53752    54074     +322     
==========================================
+ Hits        46137    46224      +87     
- Misses       7615     7850     +235     

Impacted Files	Coverage Δ
...tafusion/optimizer/src/common_subexpr_eliminate.rs	90.37% <80.64%> (-3.88%)	⬇️
datafusion/expr/src/expr.rs	75.57% <0.00%> (-11.89%)	⬇️
datafusion/expr/src/expr_rewriter.rs	79.69% <0.00%> (-6.98%)	⬇️
datafusion/physical-expr/src/crypto_expressions.rs	56.11% <0.00%> (-6.39%)	⬇️
datafusion/expr/src/expr_visitor.rs	53.68% <0.00%> (-5.62%)	⬇️
datafusion/sql/src/utils.rs	44.63% <0.00%> (-5.00%)	⬇️
datafusion/proto/src/to_proto.rs	48.89% <0.00%> (-2.19%)	⬇️
datafusion/core/src/physical_plan/planner.rs	77.39% <0.00%> (-2.06%)	⬇️
datafusion/expr/src/expr_schema.rs	61.67% <0.00%> (-1.91%)	⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ursabot]

Benchmark runs are scheduled for baseline = e032bc4 and contender = f4468ea. f4468ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java