Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Sep 3, 2022

Which issue does this PR close?

Re #3276

Rationale for this change

Implement suggestion from @andygrove on #3276 (comment)

What changes are included in this PR?

Add debug logging messages during plan teardown

Are there any user-facing changes?

no

@github-actions github-actions bot added the core Core DataFusion crate label Sep 3, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3350 (0f168d9) into master (7a53872) will decrease coverage by 0.01%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   85.46%   85.45%   -0.02%     
==========================================
  Files         294      294              
  Lines       54144    54148       +4     
==========================================
- Hits        46275    46273       -2     
- Misses       7869     7875       +6     
Impacted Files Coverage Δ
datafusion/core/src/physical_plan/common.rs 75.49% <20.00%> (-2.06%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 77.28% <0.00%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xudong963 xudong963 merged commit e26452a into apache:master Sep 3, 2022
@ursabot
Copy link

ursabot commented Sep 3, 2022

Benchmark runs are scheduled for baseline = eb8c81f and contender = e26452a. e26452a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb mentioned this pull request Sep 4, 2022
kmitchener pushed a commit to kmitchener/arrow-datafusion that referenced this pull request Sep 4, 2022
* [MINOR] Add debug logging to plan teardown

* clippy
@alamb alamb deleted the alamb/log_messages branch August 8, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants