Skip to content

Conversation

@jackwener
Copy link
Member

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

fix some typo.

Are there any user-facing changes?

None

@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions labels Sep 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3453 (79773ec) into master (c5c1dae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3453   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files         298      298           
  Lines       54645    54645           
=======================================
+ Hits        46820    46822    +2     
+ Misses       7825     7823    -2     
Impacted Files Coverage Δ
...ore/src/physical_optimizer/aggregate_statistics.rs 100.00% <ø> (ø)
...afusion/core/src/physical_optimizer/repartition.rs 100.00% <ø> (ø)
datafusion/core/src/physical_plan/stream.rs 66.66% <ø> (ø)
datafusion/core/src/test_util.rs 98.18% <ø> (ø)
datafusion/expr/src/expr_visitor.rs 56.84% <ø> (ø)
datafusion/core/src/dataframe.rs 89.21% <100.00%> (ø)
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/common/src/scalar.rs 85.12% <0.00%> (+0.06%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 77.35% <0.00%> (+0.16%) ⬆️
datafusion/expr/src/window_frame.rs 93.27% <0.00%> (+0.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @jackwener

@alamb alamb merged commit 3b8a20a into apache:master Sep 12, 2022
@ursabot
Copy link

ursabot commented Sep 12, 2022

Benchmark runs are scheduled for baseline = 7427a80 and contender = 3b8a20a. 3b8a20a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@jackwener jackwener deleted the minor branch September 13, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate logical-expr Logical plan and expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants