use prettier to auto format md files #415
Conversation
|
Now it's automatic! Neat! |
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 74.85% 74.85%
=======================================
Files 146 146
Lines 24498 24498
=======================================
Hits 18339 18339
Misses 6159 6159 Continue to review full report at Codecov.
|
| ref: ${{ github.head_ref }} | ||
|
|
||
| - name: Prettify code | ||
| uses: creyD/prettier_action@v3.3 |
There was a problem hiding this comment.
I think apache repos are limited to official github actions or ones that are local to this repo (there were some security issues previously):.
Notice: December 27, 2020: We only allow Actions that are official "Made by GitHub" or local to the Apache org on GitHub, to address a potential security vulnerability. This is an incident-related policy change. We are researching the situation, and the policy may evolve based on what we learn.
https://infra.apache.org/github-actions-secrets.html
Given https://github.com/creyD/prettier_action appears to be MIT licensed, however, what about copying the code for that action into this repo?
There was a problem hiding this comment.
good point. do you think copying it to be something under apache org repo is desired?
There was a problem hiding this comment.
good point. do you think copying it to be something under apache org repo is desired?
Yes, I think that would be preferable (the rationale being that then that someone can't change the contents of the action in the third party repository and affect the apache org via a github action)
|
FYI @Dandandan |
* Fixes Issue apache#361: Use enum to represent CAST eval_mode in expr.proto * Update expr.proto and QueryPlanSerde.scala for handling enum EvalMode for cast message * issue 361 fixed type issue for eval_mode in planner.rs * issue 361 refactored QueryPlanSerde.scala for enhanced type safety and localization compliance, including a new string-to-enum conversion function and improved import organization. * Updated planner.rs, expr.proto, QueryPlanSerde.scala for enum support * Update spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala --------- Co-authored-by: Prashant K. Sharma <prakush@foundation.local> Co-authored-by: Andy Grove <andygrove73@gmail.com>
4 participants
Which issue does this PR close?
Closes #421.
Rationale for this change
we can use
prettierto auto-format.mdor even.yamlfiles and set it as a GitHub action to auto-correct.What changes are included in this PR?
devworkflowAre there any user-facing changes?
no user facing changes as prettier would not change semantics of docs