Skip to content

Conversation

@isidentical
Copy link
Contributor

Which issue does this PR close?

Closes #4374.

Rationale for this change

Just like num_rows, we now estimate the byte size for the output of a FilterExec operation.

What changes are included in this PR?

Estimation of total byte size through filter predictivity.

Are these changes tested?

Tests are included

Are there any user-facing changes?

No

@github-actions github-actions bot added the core Core DataFusion crate label Nov 25, 2022
@isidentical isidentical marked this pull request as ready for review November 25, 2022 16:49
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @isidentical

@alamb alamb merged commit 3bfdbaa into apache:master Nov 27, 2022
@ursabot
Copy link

ursabot commented Nov 27, 2022

Benchmark runs are scheduled for baseline = 323fbb4 and contender = 3bfdbaa. 3bfdbaa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Estimate the total_byte_size of the filter expression's result when selectivity is available

3 participants