add random and now function #476
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/src/functions.rs
Outdated
| #[pyfunction] | ||
| fn now(value: expression::Expression) -> expression::Expression { | ||
| expression::Expression { | ||
| expr: logical_plan::now(value.expr), |
Member
There was a problem hiding this comment.
Do you know why the logical now has one argument? I though that the physical one had the NullArray, but that in the logical plane, the function would be zero-argument?
Member
Author
There was a problem hiding this comment.
maybe because they all take one arg which is the &[Arg]?
jimexist
changed the title
Member
Author
|
error is likely not relevant, merge after fix in #468 |
jimexist
changed the title
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 153 153
Lines 25924 25924
=======================================
Hits 19652 19652
Misses 6272 6272 Continue to review full report at Codecov.
|
jimexist
force-pushed
the
add-random-now
branch
2 times, most recently
from
614c42a to
0f644db
Compare
unkloud
pushed a commit
to unkloud/datafusion
that referenced
this pull request
Mar 23, 2025
…he#476) * fix: CometReader.loadVector should not overwrite dictionary ids * For review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #478
Depends on #483
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?