-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Define the unittests using pytest #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
- Coverage 76.09% 76.07% -0.02%
==========================================
Files 155 156 +1
Lines 26575 26750 +175
==========================================
+ Hits 20221 20351 +130
- Misses 6354 6399 +45
Continue to review full report at Codecov.
|
jorgecarleitao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
see related #484 |
|
@kszucs FYI PR now needs to be rebased. I agree btw that |
|
Do we need two requirements files? I think we only need one, for the tests? |
|
We used multiple requirements file in pyarrow for easier dependency composition. Though there are nicer ways to define multiple kinds of dependency. I don't have a strong preference, so I'm going to add pytest to the |
## Rationale for this change To be ready for Spark 4.0 ## What changes are included in this PR? This PR enables the comet tests with the spark-4.0 profile ## How are these changes tested? Tests with the spark-4.0 profile now should pass. (But Spark tests do not yet)
Rationale for this change
pytestis more convenient for writing python tests and we should be able to reuse the testing suite define inpyarrow.What changes are included in this PR?
Are there any user-facing changes?