Skip to content

Compare NULL types #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Feb 2, 2023
Merged

Compare NULL types #5158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions datafusion/core/tests/sqllogictests/test_files/pg_compat/pg_compat_type_coercion.slt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,20 +95,17 @@ select pg_typeof(false or true), pg_typeof(true or false);
bool bool


# TODO: run for DataFusion as well after #4335
onlyif postgres
query ??
select null and null, null or null;
----
NULL NULL


# TODO: uncomment after #4335
#onlyif DataFusion
#query ??
#select arrow_typeof(null and null), arrow_typeof(null or null);
#----
#Boolean Boolean
onlyif DataFusion
query ??
select arrow_typeof(null and null), arrow_typeof(null or null);
Copy link
Contributor

@alamb alamb Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

----
Boolean Boolean


onlyif postgres
Expand Down
6 changes: 3 additions & 3 deletions datafusion/expr/src/type_coercion/binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ pub fn coerce_types(
Operator::And | Operator::Or => match (lhs_type, rhs_type) {
// logical binary boolean operators can only be evaluated in bools or nulls
(DataType::Boolean, DataType::Boolean) => Some(DataType::Boolean),
(DataType::Null, DataType::Null) => Some(DataType::Null),
(DataType::Null, DataType::Null) => Some(DataType::Boolean),
(DataType::Boolean, DataType::Null) | (DataType::Null, DataType::Boolean) => {
Some(DataType::Boolean)
}
Expand Down Expand Up @@ -1147,13 +1147,13 @@ mod tests {
DataType::Null,
DataType::Null,
Operator::Or,
DataType::Null
DataType::Boolean
);
test_coercion_binary_rule!(
DataType::Null,
DataType::Null,
Operator::And,
DataType::Null
DataType::Boolean
);
test_coercion_binary_rule!(
DataType::Null,
Expand Down