From 7792c6cfbd9c99968efb5517cbdc1576af677e54 Mon Sep 17 00:00:00 2001
From: Jiayu Liu <jiayu.liu@airbnb.com>
Date: Thu, 10 Jun 2021 10:41:40 +0800
Subject: [PATCH] remove redundant into_iter() calls

---
 ballista/rust/core/src/serde/logical_plan/from_proto.rs | 2 --
 datafusion/src/physical_plan/windows.rs                 | 1 -
 datafusion/src/sql/planner.rs                           | 4 ----
 3 files changed, 7 deletions(-)

diff --git a/ballista/rust/core/src/serde/logical_plan/from_proto.rs b/ballista/rust/core/src/serde/logical_plan/from_proto.rs
index 86daeb063c47..48c2a7a8a7f6 100644
--- a/ballista/rust/core/src/serde/logical_plan/from_proto.rs
+++ b/ballista/rust/core/src/serde/logical_plan/from_proto.rs
@@ -914,13 +914,11 @@ impl TryInto<Expr> for &protobuf::LogicalExprNode {
                     .partition_by
                     .iter()
                     .map(|e| e.try_into())
-                    .into_iter()
                     .collect::<Result<Vec<_>, _>>()?;
                 let order_by = expr
                     .order_by
                     .iter()
                     .map(|e| e.try_into())
-                    .into_iter()
                     .collect::<Result<Vec<_>, _>>()?;
                 let window_frame = expr
                     .window_frame
diff --git a/datafusion/src/physical_plan/windows.rs b/datafusion/src/physical_plan/windows.rs
index 7eb14943facf..9a6b92985b51 100644
--- a/datafusion/src/physical_plan/windows.rs
+++ b/datafusion/src/physical_plan/windows.rs
@@ -348,7 +348,6 @@ fn window_aggregate_batch(
                 .collect::<Result<Vec<_>>>()?;
             window_acc.scan_batch(batch.num_rows(), values)
         })
-        .into_iter()
         .collect::<Result<Vec<_>>>()
 }
 
diff --git a/datafusion/src/sql/planner.rs b/datafusion/src/sql/planner.rs
index 53f22ecaf3f2..35c8b0f3594d 100644
--- a/datafusion/src/sql/planner.rs
+++ b/datafusion/src/sql/planner.rs
@@ -713,7 +713,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         let select_exprs = select_exprs
             .iter()
             .map(|expr| rebase_expr(expr, &window_exprs, &plan))
-            .into_iter()
             .collect::<Result<Vec<_>>>()?;
         Ok((plan, select_exprs))
     }
@@ -810,7 +809,6 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         let order_by_rex = order_by
             .iter()
             .map(|e| self.order_by_to_sort_expr(e))
-            .into_iter()
             .collect::<Result<Vec<_>>>()?;
 
         LogicalPlanBuilder::from(&plan).sort(order_by_rex)?.build()
@@ -1126,13 +1124,11 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                         .partition_by
                         .iter()
                         .map(|e| self.sql_expr_to_logical_expr(e))
-                        .into_iter()
                         .collect::<Result<Vec<_>>>()?;
                     let order_by = window
                         .order_by
                         .iter()
                         .map(|e| self.order_by_to_sort_expr(e))
-                        .into_iter()
                         .collect::<Result<Vec<_>>>()?;
                     let window_frame = window
                         .window_frame