From 84b034f75264b5471fa0ad03de499221e9080cc4 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Mon, 8 May 2023 12:28:36 -0400 Subject: [PATCH] Remove dead code for casting dictionaries --- datafusion/expr/src/type_coercion/binary.rs | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/datafusion/expr/src/type_coercion/binary.rs b/datafusion/expr/src/type_coercion/binary.rs index 3d88491c684f..7326b01b4a7e 100644 --- a/datafusion/expr/src/type_coercion/binary.rs +++ b/datafusion/expr/src/type_coercion/binary.rs @@ -504,16 +504,6 @@ fn mathematics_numerical_coercion( return None; }; - // same type => all good - // TODO: remove this - // bug: https://github.com/apache/arrow-datafusion/issues/3387 - if lhs_type == rhs_type - && !(matches!(lhs_type, DataType::Dictionary(_, _)) - || matches!(rhs_type, DataType::Dictionary(_, _))) - { - return Some(lhs_type.clone()); - } - // these are ordered from most informative to least informative so // that the coercion removes the least amount of information match (lhs_type, rhs_type) {