Support CREATE TABLE via SQL for infinite streams #6352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprimadi
changed the title
github-actions
bot
added
core
|
cc @ozankabak and @mustafasrepo |
| /// File compression type (GZIP, BZIP2, XZ, ZSTD) | ||
| pub file_compression_type: CompressionTypeVariant, | ||
| /// Whether the table is an infinite streams | ||
| pub unbounded: bool, |
There was a problem hiding this comment.
I think, fn hash<H: Hasher>(&self, state: &mut H) function should use self.unbounded during hashing also.
There was a problem hiding this comment.
Ah yes, I miss that
| self.parser.expect_keyword(Keyword::ROW)?; | ||
| ensure_not_set(&builder.has_header, "WITH HEADER ROW")?; | ||
| builder.has_header = Some(true); | ||
| if let Some(keyword) = self.parser.parse_one_of_keywords(&[ |
|
This PR is LGTM!. Thanks @aprimadi for this work. |
mustafasrepo
previously approved these changes
May 16, 2023
mustafasrepo
dismissed
their stale review
After unbounded information is used in hash function I will approve this PR. Someone may see this PR approved, then may merge this, before that feature is addressed.
mustafasrepo
approved these changes
May 16, 2023
|
Thank you for the review @mustafasrepo |
|
Thanks @aprimadi and @mustafasrepo ! |
|
🤔 github seems to be acting up (not merging this PR). |
|
@alamb is it supposed to merge automatically? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6251
Rationale for this change
N/A
What changes are included in this PR?
CREATE UNBOUNDED EXTERNAL TABLE ...statementAre these changes tested?
Yes
Are there any user-facing changes?
No API change. Add more SQL functionality.