Minor: Simplify date_trunc code and add comments
#6783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jun 27, 2023
| let Some(nano) = (f)(Some(value * scale))? else { | ||
| return Ok(None); | ||
| }; | ||
| let nano = date_trunc_coarse(granularity, scale * value)?; |
Contributor
Author
There was a problem hiding this comment.
There is no need for a closure, and the function can be called directly which I think makes things easier to understand
alamb
commented
Jun 27, 2023
Contributor
Author
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
The date_trunc code could be quite a bit faster if it did not check the granularity on each row but instead did that once per column. That can be an optimization for some later time
| } | ||
|
|
||
| fn date_trunc_single(granularity: &str, value: i64) -> Result<i64> { | ||
| /// Tuncates the single `value`, expressed in nanoseconds since the |
Contributor
Author
There was a problem hiding this comment.
I think this is correct -- @Weijun-H does it match your understanding?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #6654 from @Weijun-H (❤️ )
Rationale for this change
While reviewing #6654 and trying to answer @viirya 's question here #6654 (comment)
What changes are included in this PR?
date_trunc_singletodate_trunc_coarseto better explain what it doesAre these changes tested?
Covered by the (very) nice existing tests added in #6654
Are there any user-facing changes?
No