Skip to content

Conversation

@jimexist
Copy link
Member

@jimexist jimexist commented Jul 14, 2021

Which issue does this PR close?

split up windows functions into a dedicated module with separate files

Closes #.

Rationale for this change

in future window functions are getting more and more complex, so we split it up to make it more self-contained and easier to manager

What changes are included in this PR?

purely code refactoring, not logic changes

Are there any user-facing changes?

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me -- thank you @jimexist

It looks like this PR has conflicts now -- likely due to #687

@jimexist jimexist force-pushed the split-window-funcs branch from f396f1a to b376576 Compare July 15, 2021 02:19
@jimexist jimexist force-pushed the split-window-funcs branch from b376576 to 267e852 Compare July 15, 2021 05:13
@alamb alamb merged commit e24155e into apache:master Jul 15, 2021
@jimexist jimexist deleted the split-window-funcs branch July 15, 2021 13:06
unkloud pushed a commit to unkloud/datafusion that referenced this pull request Mar 23, 2025
* Use new logo in README and website

* update discord link

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants