Remove redundant is_numeric for DataType #7734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's available in arrow-rs since version 3.0.0 Resolves apache#1613
github-actions
bot
added
logical-expr
|
I didn't find any other methods from |
alamb
approved these changes
Oct 3, 2023
viirya
approved these changes
Oct 3, 2023
Ted-Jiang
pushed a commit
to Ted-Jiang/arrow-datafusion
that referenced
this pull request
Oct 7, 2023
It's available in arrow-rs since version 3.0.0 Resolves apache#1613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
is_numericis available inarrow-rssince version 3.0.0Which issue does this PR close?
Closes #1613 .
Rationale for this change
Remove redundant code
What changes are included in this PR?
is_numeric removed, replaced with DataType::is_numeric
Are these changes tested?
Tested with
cargo testAre there any user-facing changes?
No user-facing changes