feat:implement calcite style 'levenshtein' string function #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
alamb
reviewed
Nov 14, 2023
There was a problem hiding this comment.
Thank you for the contribution @Syleechan . I think we can avoid the new dependency but otherwise this looks great
datafusion/physical-expr/Cargo.toml
Outdated
| @@ -67,6 +67,7 @@ regex = { version = "1.8", optional = true } | |||
| sha2 = { version = "^0.10.1", optional = true } | |||
| unicode-segmentation = { version = "^1.7.1", optional = true } | |||
| uuid = { version = "^1.2", features = ["v4"] } | |||
| edit-distance = "2.1.0" | |||
There was a problem hiding this comment.
I think we can avoid this new dependency by either reusing our existing implementation (see below)
# Conflicts: # datafusion/proto/proto/datafusion.proto # datafusion/proto/src/generated/pbjson.rs # datafusion/proto/src/generated/prost.rs # datafusion/proto/src/logical_plan/from_proto.rs
|
@alamb thanks, I have changed to use exsiting implementation. But the code checks maybe something wrong, I have used the checking command to run local all have passed. |
|
I believe the failures are due to some logical conflicts since fixed in #8187 Updating to the latest main should work I think |
# Conflicts: # datafusion/proto/proto/datafusion.proto # datafusion/proto/src/generated/pbjson.rs # datafusion/proto/src/generated/prost.rs
|
@alamb thanks, it works. And wait for your code review. |
alamb
approved these changes
Nov 16, 2023
Ted-Jiang
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
https://calcite.apache.org/docs/reference.html#:~:text=LEVENSHTEIN(string1%2C%20string2,string1%20and%20string2
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?