Minor: refactor trim to clean up duplicated code
#8434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
alamb
approved these changes
Dec 8, 2023
| } | ||
| } | ||
|
|
||
| /// Removes the longest string containing only characters in characters (a space by default) from the start and end of string. | ||
| /// btrim('xyxtrimyyx', 'xyz') = 'trim' |
There was a problem hiding this comment.
It might help to explain what characters is here -- specifically args[1] if present
Weijun-H
force-pushed
the
refactor-trim
branch
from
47e7cfb
to
ec7d7ac
Compare
alamb
approved these changes
Dec 9, 2023
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
* refactor trim * add fmt for TrimType * fix closure * update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?