From 0484170986c313c2e8cd0da0e73b1882a92aba05 Mon Sep 17 00:00:00 2001 From: Tommi Virtanen Date: Wed, 7 Feb 2024 14:43:00 -0700 Subject: [PATCH] RecordBatchReceiverStreamBuilder: don't stringify errors The error is a DataFusionError already, so don't stringify it, just use it as-is. --- datafusion/physical-plan/src/stream.rs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/datafusion/physical-plan/src/stream.rs b/datafusion/physical-plan/src/stream.rs index e4ef6c4238653..b780a50cdc901 100644 --- a/datafusion/physical-plan/src/stream.rs +++ b/datafusion/physical-plan/src/stream.rs @@ -24,9 +24,9 @@ use std::task::Poll; use crate::displayable; use arrow::{datatypes::SchemaRef, record_batch::RecordBatch}; +use datafusion_common::internal_err; use datafusion_common::DataFusionError; use datafusion_common::Result; -use datafusion_common::{exec_err, internal_err}; use datafusion_execution::TaskContext; use futures::stream::BoxStream; use futures::{Future, Stream, StreamExt}; @@ -116,9 +116,7 @@ impl ReceiverStreamBuilder { // nothing to report Ok(_) => continue, // This means a blocking task error - Err(e) => { - return Some(exec_err!("Spawned Task error: {e}")); - } + Err(error) => return Some(Err(error)), } } // This means a tokio task error, likely a panic