Skip to content

Minor: Return InternalError rather than panic for NamedStructField should be rewritten in OperatorToFunction #9968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayzhan211 merged 2 commits into from
Apr 6, 2024
Merged

Minor: Return InternalError rather than panic for NamedStructField should be rewritten in OperatorToFunction #9968

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6333b
Minor: Return InternalError rather than panic for 'NamedStructField s…
alamb Apr 5, 2024
025bec9
clippy
alamb Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 17 additions & 19 deletions datafusion/physical-expr/src/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,25 +283,23 @@ pub fn create_physical_expr(
input_dfschema,
execution_props,
)?),
Expr::GetIndexedField(GetIndexedField { expr: _, field }) => {
match field {
GetFieldAccess::NamedStructField { name: _ } => {
unreachable!(
"NamedStructField should be rewritten in OperatorToFunction"
)
}
GetFieldAccess::ListIndex { key: _ } => {
unreachable!("ListIndex should be rewritten in OperatorToFunction")
}
GetFieldAccess::ListRange {
start: _,
stop: _,
stride: _,
} => {
unreachable!("ListRange should be rewritten in OperatorToFunction")
}
};
}
Expr::GetIndexedField(GetIndexedField { expr: _, field }) => match field {
GetFieldAccess::NamedStructField { name: _ } => {
internal_err!(
"NamedStructField should be rewritten in OperatorToFunction"
)
}
GetFieldAccess::ListIndex { key: _ } => {
internal_err!("ListIndex should be rewritten in OperatorToFunction")
}
GetFieldAccess::ListRange {
start: _,
stop: _,
stride: _,
} => {
internal_err!("ListRange should be rewritten in OperatorToFunction")
}
},

Expr::ScalarFunction(ScalarFunction { func_def, args }) => {
let physical_args =
Expand Down