Add @Description to UDFs registered in Apache Hive #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
force-pushed
the
udf-descriptions-warning
branch
from
ed1f875 to
53d0249
Compare
| value = "_FUNC_(firstSketch, secondSketch[, lgK[, seed]]) - Compute the union of the given " | ||
| + "sketches with the given size and seed", | ||
| extended = "The return value is a binary blob that can be operated on by other sketch related functions." | ||
| + " The lgK parameter controls the sketch size and rlative error expected from the sketch." |
There was a problem hiding this comment.
Thanks. I fixed all typos. Please let me know if you prefer to have separate PRs.
e3bafbe
$ git grep rlative
src/main/java/org/apache/datasketches/hive/cpc/DataToSketchUDAF.java: + " The lgK parameter controls the sketch size and rlative error expected from the sketch."
src/main/java/org/apache/datasketches/hive/cpc/UnionSketchUDAF.java: + " The lgK parameter controls the sketch size and rlative error expected from the sketch."
src/main/java/org/apache/datasketches/hive/cpc/UnionSketchUDF.java: + " The lgK parameter controls the sketch size and rlative error expected from the sketch."
src/main/java/org/apache/datasketches/hive/hll/DataToSketchUDAF.java: + " The lgK parameter controls the sketch size and rlative error expected from the sketch."
src/main/java/org/apache/datasketches/hive/hll/UnionSketchUDAF.java: + " The lgK parameter controls the sketch size and rlative error expected from the sketch."
src/main/java/org/apache/datasketches/hive/hll/UnionSketchUDF.java: + " The lgK parameter controls the sketch size and rlative error expected from the sketch."
| value = "_FUNC_(firstSketch, secondSketch[, lgK[, type]]) - Compute the union of the given " | ||
| + "sketches with the given size and seed", | ||
| extended = "The return value is a binary blob that can be operated on by other sketch related functions." | ||
| + " The lgK parameter controls the sketch size and rlative error expected from the sketch." |
AlexanderSaydakov
approved these changes
Feb 22, 2023
|
Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observe many WARN logs when using Hive 4. Please feel free to ask me to update if my description doesn't make sense.