Skip to content
Permalink
Browse files
Remove java9-tests module
This module does not compile in Eclipse due to additional
checks that Eclipse performs on the module path vs class
path.
  • Loading branch information
davecromberge committed Jul 12, 2021
1 parent a26fd9e commit 1adf0eae6210663cd0ed7d8659289dad2950f966
Showing 12 changed files with 0 additions and 244 deletions.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

@@ -23,5 +23,4 @@
requires jdk.unsupported;

exports org.apache.datasketches.memory;
exports org.apache.datasketches.memory.internal to org.apache.datasketches.memory.tests;
}
@@ -140,12 +140,6 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-memory-java9-tests</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<!-- Used for UTF8 testing -->
<groupId>com.google.protobuf</groupId>
@@ -16,7 +16,6 @@ should be set as follows:
| datasketches-memory-java8 | 8 |
| datasketches-memory-java8-tests | 8 |
| datasketches-memory-java9 | 9 |
| datasketches-memory-java9-tests | 9 |
| datasketches-memory-java11 | 11 |

#### Compiler arguments for JPMS
@@ -16,7 +16,6 @@ should be set as follows:
| datasketches-memory-java8 | 8 |
| datasketches-memory-java8-tests | 8 |
| datasketches-memory-java9 | 9 |
| datasketches-memory-java9-tests | 9 |
| datasketches-memory-java11 | 11 |

#### Compiler arguments for JPMS
@@ -14,7 +14,6 @@ This project has been divided into the following submodules:
* datasketches-memory-java8 (base version of the JVM that is currently supported)
* datasketches-memory-java8-tests
* datasketches-memory-java9 (Java9 equivalent of some platform specific classes in datasketches-memory-java8)
* datasketches-memory-java9-tests
* datasketches-memory-java11 (Java11 equivalent of some platform specific classes in datasketches-memory-java8)
* datasketches-memory-java11-tests
* datasketches-memory (JAR assembly, does not contain source files)
@@ -87,19 +87,6 @@ The following runtime arguments should be provided when using the library:
--add-opens java.base/jdk.internal.ref=org.apache.datasketches.memory
```

In order to run unit tests, the Maven surefire plugin also requires similar runtime arguments in the
`datasketches-memory-java9-tests Maven submodule pom.xml:
```xml
<configuration>
<argLine>
--add-opens java.base/jdk.internal.ref=org.apache.datasketches.memory
--add-opens java.base/jdk.internal.misc=org.apache.datasketches.memory
--add-exports org.apache.datasketches.memory.tests/org.apache.datasketches.memory.test=org.testng
</argLine>
</configuration>
```

### JPMS and Java 8

Java 8 does not support module declarations and the JPMS module system.
@@ -503,7 +503,6 @@ under the License.
<module>datasketches-memory-java8</module>
<module>datasketches-memory-java8-tests</module>
<module>datasketches-memory-java9</module>
<module>datasketches-memory-java9-tests</module>
<module>datasketches-memory-java11</module>
<module>datasketches-memory</module>
<module>datasketches-memory-tests</module>

0 comments on commit 1adf0ea

Please sign in to comment.