Skip to content
Permalink
Browse files
Removed false positives where strict profile was complaining.
update pom, bash script.

Prepare for next Release Candidate
  • Loading branch information
leerho committed Jul 23, 2019
1 parent 5a0e03f commit ec8f16e111176f8201d2be8a5a4eff140f0163b5
Showing 4 changed files with 73 additions and 38 deletions.
89 pom.xml
@@ -31,7 +31,7 @@ under the License.
<groupId>org.apache.datasketches</groupId>
<artifactId>datasketches-memory</artifactId>

<version>0.12.3-incubating-SNAPSHOT</version>
<version>1.0.0-incubating</version>

<name>${project.groupId}:${project.artifactId}</name>
<description>High-performance native memory access.</description>
@@ -121,6 +121,7 @@ under the License.

<!-- Maven Plugins -->
<maven-jar-plugin.version>3.1.2</maven-jar-plugin.version>
<maven-gpg-plugin.version>1.6</maven-gpg-plugin.version>

<!-- org.jacoco Maven Plugins -->
<jacoco-maven-plugin.version>0.8.4</jacoco-maven-plugin.version>
@@ -194,38 +195,28 @@ under the License.
<build>
<plugins>
<!-- We want to deploy the artifacts to a staging location for perusal -->
<!-- exact duplicate of Parent -->
<plugin>
<inherited>true</inherited>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-deploy-plugin</artifactId>
<!-- version in parent -->
<!-- Apache Parent pom, apache-release profile -->
<!-- Druid: PM, Beam 2.4: release, Pinot: none, Dubbo: build -->
<configuration>
<updateReleaseInfo>true</updateReleaseInfo>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<!-- version in parent -->
</plugin>

<!-- exact duplicate of Parent -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<!-- version in parent -->
<executions>
<execution>
<id>sign-release-artifacts</id>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
<!-- Apache Parent pom, pluginManagement-->
<!-- Druid: PM, Beam 2.4: PM, Pinot: PM, Dubbo: build -->
</plugin>

<plugin> <!-- extends the Parent -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<!-- Apache Parent pom, pluginManagement-->
<!-- Druid: none, Beam 2.4: PM, Pinot: PM, Dubbo: build -->
<version>${maven-jar-plugin.version}</version>
<executions>
<execution>
@@ -249,7 +240,8 @@ under the License.
<plugin> <!-- extends the Parent -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<!-- version in parent -->
<!-- Apache Parent pom, apache-release profile -->
<!-- Druid: PM, Beam 2.4: release profile, Pinot: build, reporting, Dubbo: release -->
<configuration>
<!--
<show>private</show>
@@ -270,7 +262,8 @@ under the License.
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<!-- version in parent -->
<!-- Apache Parent pom, pluginManagement-->
<!-- Druid: rat profile, Beam 2.4: release profile, Pinot: build, reporting, Dubbo: build -->
<executions>
<execution>
<phase>verify</phase>
@@ -297,7 +290,8 @@ under the License.
<plugin> <!-- extends parent -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<!-- version in parent -->
<!-- Apache Parent pom, apache-release profile -->
<!-- Druid: none, Beam 2.4: release profile, Pinot: PM, Dubbo: build -->
<executions>
<execution>
<id>attach-sources</id>
@@ -319,7 +313,8 @@ under the License.
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<!-- version in parent -->
<!-- Apache Parent pom, pluginManagement-->
<!-- Druid: profiles: java9+, parallelTest, Beam 2.4: PM, Pinot: build, travis profile, Dubbo: build -->
<configuration>
<trimStackTrace>false</trimStackTrace>
<useManifestOnlyJar>false</useManifestOnlyJar>
@@ -331,6 +326,7 @@ under the License.
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
<!-- Druid: none; Beam 2.4: PM; Pinot: build; Dubbo: build -->
<version>${jacoco-maven-plugin.version}</version>
<executions>
<execution>
@@ -347,6 +343,7 @@ under the License.
<groupId>org.eluder.coveralls</groupId>
<artifactId>coveralls-maven-plugin</artifactId>
<version>${coveralls-maven-plugin.version}</version>
<!-- Druid: build; Beam 2.4: PM; Pinot: none; Dubbo: none -->
<configuration>
<!-- Since we use Travis CI we do not have to put a Coveralls token here. -->
</configuration>
@@ -355,6 +352,7 @@ under the License.
<groupId>io.github.zlika</groupId>
<artifactId>reproducible-build-maven-plugin</artifactId>
<version>${reproducible-build-maven-plugin.version}</version>
<!-- Druid: none; Beam 2.4: release profile; Pinot: none; Dubbo: none -->
<executions>
<execution>
<goals>
@@ -440,5 +438,48 @@ under the License.
</pluginManagement>
</build>
</profile>

<profile>
<id>sign</id>
<build>
<plugins>
<!-- We want to sign the artifacts, POM, and all attached artifacts -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<!-- Apache Parent pom, PM, apache-release profile -->
<!-- Druid: none; Beam 2.4: sign profile, Pinot: none, Dubbo: release profile -->
<version>${maven-gpg-plugin.version}</version>
<executions>
<execution>
<id>sign-release-artifacts</id>
<goals>
<goal>sign</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

<!-- Disable source release assembly for 'apache-release' profile. -->
<profile>
<id>apache-release</id>
<build>
<plugins>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<id>source-release-assembly</id>
<phase>none</phase>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>

</profiles>
</project>
@@ -118,8 +118,8 @@ else
echo "This Tag is for a Release Candidate."
echo "Proceed? [y|N]"; read confirm; if [[ $confirm != "y" ]]; then echo "Please rerun this script when ready."; exit 1; fi
ReleaseCandidate=true
# RCSubStr=$(expr "$Tag" : '.*\(-[rR][cC][0-9]*\)')
FileVersion=$Tag # ${Tag%$RCSubStr}
RCSubStr=$(expr "$Tag" : '.*\(-[rR][cC][0-9]*\)')
FileVersion=${Tag%$RCSubStr}
LeafDir="$Tag"
else
echo "Please confirm that this the Final Release of $ProjectArtifactId : $Tag"
@@ -83,10 +83,10 @@ public void checkSelfArrayCopy() {
public void checkEquals() {
int len = 7;
WritableMemory wmem1 = WritableMemory.allocate(len);
@SuppressWarnings({"EqualsWithItself", "SelfEquals"})
//@SuppressWarnings({"EqualsWithItself", "SelfEquals"}) //unsupported
//SelfEquals for Plexus, EqualsWithItself for IntelliJ
boolean eq1 = wmem1.equals(wmem1);
assertTrue(eq1);
//boolean eq1 = wmem1.equals(wmem1); //strict profile complains
//assertTrue(eq1);

WritableMemory wmem2 = WritableMemory.allocate(len + 1);
assertFalse(wmem1.equals(wmem2));
@@ -126,10 +126,10 @@ public void checkEquals2() {
int len = 23;
WritableMemory wmem1 = WritableMemory.allocate(len);
assertFalse(wmem1.equals(null));
@SuppressWarnings({"EqualsWithItself", "SelfEquals"})
//@SuppressWarnings({"EqualsWithItself", "SelfEquals"}) //unsupported
//SelfEquals for Plexus, EqualsWithItself for IntelliJ
boolean eq1 = wmem1.equals(wmem1);
assertTrue(eq1);
//boolean eq1 = wmem1.equals(wmem1); //strict profile complains
//assertTrue(eq1);

WritableMemory wmem2 = WritableMemory.allocate(len + 1);
assertFalse(wmem1.equals(wmem2));
@@ -104,12 +104,6 @@ public void collisionTest() {
assertEquals(h2, h3);
}

// @Test
// public void fixOverflow() {
// long out = 0x9C90005B80000000L * 2L;
// System.out.println(Long.toHexString(out));
// }

/**
* This simple test compares the output of {@link BaseState#xxHash64(long, long, long)} with the
* output of {@link net.openhft.hashing.LongHashFunction}, that itself is tested against the

0 comments on commit ec8f16e

Please sign in to comment.