diff --git a/plugins/github/api/connection.go b/plugins/github/api/connection.go index e7e4bf6c3e4..3cff808cc49 100644 --- a/plugins/github/api/connection.go +++ b/plugins/github/api/connection.go @@ -173,7 +173,7 @@ func DeleteConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, er return nil, err } err = connectionHelper.Delete(connection) - return &core.ApiResourceOutput{Body: connection}, err + return &core.ApiResourceOutput{Body: connection}, nil } // @Summary get all github connections @@ -206,5 +206,5 @@ func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error if err != nil { return nil, err } - return &core.ApiResourceOutput{Body: connection}, err + return &core.ApiResourceOutput{Body: connection}, nil } diff --git a/plugins/gitlab/api/connection.go b/plugins/gitlab/api/connection.go index e60417fac2a..22b1a539af6 100644 --- a/plugins/gitlab/api/connection.go +++ b/plugins/gitlab/api/connection.go @@ -159,6 +159,9 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.GitlabConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } diff --git a/plugins/jenkins/api/connection.go b/plugins/jenkins/api/connection.go index edd72385bc5..be180c2e824 100644 --- a/plugins/jenkins/api/connection.go +++ b/plugins/jenkins/api/connection.go @@ -161,6 +161,9 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.JenkinsConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } diff --git a/plugins/jira/api/connection.go b/plugins/jira/api/connection.go index 1cc95c80c8c..1c0715047ac 100644 --- a/plugins/jira/api/connection.go +++ b/plugins/jira/api/connection.go @@ -210,5 +210,8 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.JiraConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } diff --git a/plugins/tapd/api/connection.go b/plugins/tapd/api/connection.go index 4b1f3609d82..1120ddbbf77 100644 --- a/plugins/tapd/api/connection.go +++ b/plugins/tapd/api/connection.go @@ -164,5 +164,8 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.TapdConnection{} err := connectionHelper.First(connection, input.Params) - return &core.ApiResourceOutput{Body: connection}, err + if err != nil { + return nil,err + } + return &core.ApiResourceOutput{Body: connection},nil }