From 50c404f3eb21f3b63bbbeb849265deb90871f38f Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Thu, 21 Jul 2022 11:05:46 +0530 Subject: [PATCH 1/7] perf: added the error handling Added the error handling in GetConnection --- plugins/gitlab/api/connection.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/gitlab/api/connection.go b/plugins/gitlab/api/connection.go index e60417fac2a..22b1a539af6 100644 --- a/plugins/gitlab/api/connection.go +++ b/plugins/gitlab/api/connection.go @@ -159,6 +159,9 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.GitlabConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } From a78ab4f3a1cd14f67d2ff0431cf6b3290d80c914 Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Thu, 21 Jul 2022 11:07:53 +0530 Subject: [PATCH 2/7] perf: added the error handling added the error handling in GetConnection --- plugins/jenkins/api/connection.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/jenkins/api/connection.go b/plugins/jenkins/api/connection.go index edd72385bc5..be180c2e824 100644 --- a/plugins/jenkins/api/connection.go +++ b/plugins/jenkins/api/connection.go @@ -161,6 +161,9 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.JenkinsConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } From c8c4467193f008da1b62e85fac3433afc1bed696 Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Thu, 21 Jul 2022 11:09:41 +0530 Subject: [PATCH 3/7] perf: added the error handling added the error handling GetConnection --- plugins/jira/api/connection.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/jira/api/connection.go b/plugins/jira/api/connection.go index 1cc95c80c8c..1c0715047ac 100644 --- a/plugins/jira/api/connection.go +++ b/plugins/jira/api/connection.go @@ -210,5 +210,8 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.JiraConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } From 10f3c2b1bc57284123dd9b2f6de2fba99b19a563 Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Thu, 21 Jul 2022 11:10:50 +0530 Subject: [PATCH 4/7] perf: added the error handling added the error handling GetConnection --- plugins/tapd/api/connection.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/tapd/api/connection.go b/plugins/tapd/api/connection.go index 4b1f3609d82..b582bed7b8f 100644 --- a/plugins/tapd/api/connection.go +++ b/plugins/tapd/api/connection.go @@ -164,5 +164,8 @@ func ListConnections(input *core.ApiResourceInput) (*core.ApiResourceOutput, err func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { connection := &models.TapdConnection{} err := connectionHelper.First(connection, input.Params) + if err != nil { + return nil, err + } return &core.ApiResourceOutput{Body: connection}, err } From 9b333016295eb63b5e05eca966079dadf51fe0a7 Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Fri, 22 Jul 2022 16:05:01 +0530 Subject: [PATCH 5/7] perf: edited err to nil edited the err handling err to nil --- plugins/tapd/api/connection.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/tapd/api/connection.go b/plugins/tapd/api/connection.go index b582bed7b8f..415df7cb97f 100644 --- a/plugins/tapd/api/connection.go +++ b/plugins/tapd/api/connection.go @@ -165,7 +165,7 @@ func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error connection := &models.TapdConnection{} err := connectionHelper.First(connection, input.Params) if err != nil { - return nil, err + return nil,err } - return &core.ApiResourceOutput{Body: connection}, err + return &core.ApiResourceOutput{Body: connection}, nil } From edf4f9105db3f21c4452118a4abb1673a4d4ed07 Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Fri, 22 Jul 2022 16:55:49 +0530 Subject: [PATCH 6/7] perf: added nil for error handling changed err to nil --- plugins/tapd/api/connection.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/tapd/api/connection.go b/plugins/tapd/api/connection.go index 415df7cb97f..1120ddbbf77 100644 --- a/plugins/tapd/api/connection.go +++ b/plugins/tapd/api/connection.go @@ -167,5 +167,5 @@ func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error if err != nil { return nil,err } - return &core.ApiResourceOutput{Body: connection}, nil + return &core.ApiResourceOutput{Body: connection},nil } From 534351c8fa50c050d411edb2211a35524b7533d2 Mon Sep 17 00:00:00 2001 From: PRANSHU RAJ <50316017+Pranshu-Raj@users.noreply.github.com> Date: Thu, 4 Aug 2022 02:04:33 +0530 Subject: [PATCH 7/7] added error handling --- plugins/github/api/connection.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/github/api/connection.go b/plugins/github/api/connection.go index e7e4bf6c3e4..3cff808cc49 100644 --- a/plugins/github/api/connection.go +++ b/plugins/github/api/connection.go @@ -173,7 +173,7 @@ func DeleteConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, er return nil, err } err = connectionHelper.Delete(connection) - return &core.ApiResourceOutput{Body: connection}, err + return &core.ApiResourceOutput{Body: connection}, nil } // @Summary get all github connections @@ -206,5 +206,5 @@ func GetConnection(input *core.ApiResourceInput) (*core.ApiResourceOutput, error if err != nil { return nil, err } - return &core.ApiResourceOutput{Body: connection}, err + return &core.ApiResourceOutput{Body: connection}, nil }