From 1428549a4eee773e1f90129638383c7e05d15951 Mon Sep 17 00:00:00 2001 From: abeizn Date: Thu, 6 Jun 2024 11:13:07 +0800 Subject: [PATCH] fix: pr commit 404 --- .../bitbucket_server/tasks/pr_commit_collector.go | 1 + backend/plugins/bitbucket_server/tasks/task_data.go | 12 ++++++++++++ 2 files changed, 13 insertions(+) diff --git a/backend/plugins/bitbucket_server/tasks/pr_commit_collector.go b/backend/plugins/bitbucket_server/tasks/pr_commit_collector.go index 1fd69f02409..dabf58823f9 100644 --- a/backend/plugins/bitbucket_server/tasks/pr_commit_collector.go +++ b/backend/plugins/bitbucket_server/tasks/pr_commit_collector.go @@ -57,6 +57,7 @@ func CollectApiPullRequestCommits(taskCtx plugin.SubTaskContext) errors.Error { Input: iterator, UrlTemplate: "rest/api/1.0/projects/{{ .Params.FullName }}/pull-requests/{{ .Input.BitbucketId }}/commits", ResponseParser: GetRawMessageFromResponse, + AfterResponse: ignoreHTTPStatus404, }) if err != nil { return err diff --git a/backend/plugins/bitbucket_server/tasks/task_data.go b/backend/plugins/bitbucket_server/tasks/task_data.go index 45d6c98586b..dd2571e79b6 100644 --- a/backend/plugins/bitbucket_server/tasks/task_data.go +++ b/backend/plugins/bitbucket_server/tasks/task_data.go @@ -18,6 +18,8 @@ limitations under the License. package tasks import ( + "net/http" + "github.com/apache/incubator-devlake/core/errors" "github.com/apache/incubator-devlake/helpers/pluginhelper/api" "github.com/apache/incubator-devlake/plugins/bitbucket_server/models" @@ -77,3 +79,13 @@ func ValidateTaskOptions(op *BitbucketServerOptions) errors.Error { } return nil } + +func ignoreHTTPStatus404(res *http.Response) errors.Error { + if res.StatusCode == http.StatusUnauthorized { + return errors.Unauthorized.New("authentication failed, please check your AccessToken") + } + if res.StatusCode == http.StatusNotFound { + return api.ErrIgnoreAndContinue + } + return nil +}