Skip to content
Permalink
Browse files
[chore] Migrate development docs into main repo (#769)
* [chore] Migrate docs to main repo

* add new file in gitignore

* rm dev dir

* rm dev dir

* rm dev imgs

* change architecture

* add img/architecture-design/ to gitignore

* change shell script

* disable github review temp
  • Loading branch information
zhongjiajie committed Apr 14, 2022
1 parent e856cf0 commit 1691d6f4d4257225b17b8177c4fdda06651a4b1c
Showing 49 changed files with 16 additions and 3,361 deletions.
@@ -46,3 +46,7 @@ swap/
docs/
site_config/docs*.js
site_config/site.js
src/pages/docs/index.md.jsx
# development resource
development/
img/architecture-design/
@@ -87,6 +87,7 @@ When an Issue need to create Pull Requests, you could also labeled it from below
### Pull Requests

<!-- markdown-link-check-disable -->
Review Pull mean discussing in [Pull Requests][all-PRs] in GitHub and giving suggestions to it. DolphinScheduler's
Pull Requests reviewing are the same as [GitHub's reviewing changes in pull requests][gh-review-pr]. You can give your
suggestions in Pull Requests
@@ -97,6 +98,7 @@ suggestions in Pull Requests
[GitHub's reviewing changes in pull requests][gh-review-pr]. And when you think issues that must be fixed before they
merged, please follow "Request changes" in [GitHub's reviewing changes in pull requests][gh-review-pr] to ask contributors
modify it.
<!-- markdown-link-check-enable -->

Labeled Pull Requests is an important part. Reasonable classification can save a lot of time for reviewers. The good news
is that the label's name and usage of Pull Requests are the same in [Issues](#issues), which can reduce the memory. For
@@ -79,6 +79,7 @@ Review Issues 是指在 GitHub 中参与 [Issues][all-issues] 的讨论,并在
### Pull Requests

<!-- markdown-link-check-disable -->
Review Pull 是指在 GitHub 中参与 [Pull Requests][all-PRs] 的讨论,并在对应的 Pull Requests 给出建议。DolphinScheduler review
Pull Requests 与 [GitHub 的 reviewing changes in pull requests][gh-review-pr] 一样。你可以为 Pull Requests 提出自己的看法,

@@ -87,6 +88,7 @@ Pull Requests 与 [GitHub 的 reviewing changes in pull requests][gh-review-pr]
* 当你觉得这个 Pull Requests 需要被修改时,可以根据 [GitHub 的 reviewing changes in pull requests][gh-review-pr] 的 comment
流程评论这个 Pull Requests。当你认为存在一定要先修复才能合并的问题,请参照 [GitHub 的 reviewing changes in pull requests][gh-review-pr]
的 Request changes 流程要求贡献者修改 Pull Requests 的内容。
<!-- markdown-link-check-enable -->

为 Pull Requests 打上标签也是非常重要的一个环节,合理的分类能为后来的 reviewer 节省大量的时间。值得高兴的是,Pull Requests 的标签和 [Issues](#issues)
中提及的标签和用法是一致的,这能减少 reviewer 对标签的记忆。例如这个 Pull Requests 是和 docker 并且直接影响到用户部署的,我们可以为他

This file was deleted.

0 comments on commit 1691d6f

Please sign in to comment.