Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Permission] Reconstruction of permissions of resource center and monitoring center. #10307

Merged
merged 4 commits into from
May 31, 2022

Conversation

WangJPLeo
Copy link
Contributor

Purpose of the pull request

Abstract functions, resource permission verification, and reconstruction of project management, security center, data source center, data quality, resource center and monitoring center module permission management.

Brief change log

close #10306

Verify this pull request

Manually verified the change by testing locally.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

56.5% 56.5% Coverage
1.2% 1.2% Duplication

Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

</if>
<!-- <if test="userId != 0">-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete the unused code. Maybe you can fix it later

</foreach>
</if>
)
where d.type=#{type} and d.pid=#{id} and u.id = #{userId}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no need d.user_id = u.id ?

ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
…r and monitoring center. (apache#10307)

* Reconstruction of permissions of resource center and monitoring center.

* clear local logs.

* resource query fix
@Leijingwen
Copy link

Leijingwen commented Sep 30, 2022

image
image

Why is the code written disabled?

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants