Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability in LDAP login #11586

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Fix vulnerability in LDAP login #11586

merged 1 commit into from
Aug 22, 2022

Conversation

kezhenxu94
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@kezhenxu94 kezhenxu94 self-assigned this Aug 22, 2022
@kezhenxu94 kezhenxu94 added the bug Something isn't working label Aug 22, 2022
SbloodyS
SbloodyS previously approved these changes Aug 22, 2022
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS added this to the 3.0.1 milestone Aug 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #11586 (091d6a6) into dev (5813a61) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##                dev   #11586   +/-   ##
=========================================
  Coverage     39.79%   39.79%           
  Complexity     4696     4696           
=========================================
  Files           993      993           
  Lines         37662    37662           
  Branches       4187     4187           
=========================================
+ Hits          14987    14988    +1     
+ Misses        21109    21108    -1     
  Partials       1566     1566           
Impacted Files Coverage Δ
...nscheduler/api/security/impl/ldap/LdapService.java 6.38% <0.00%> (ø)
...r/plugin/task/sqoop/parameter/SqoopParameters.java 56.41% <0.00%> (+1.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kezhenxu94 kezhenxu94 merged commit 17a9dd2 into dev Aug 22, 2022
@kezhenxu94 kezhenxu94 deleted the bugfix/ldap branch August 22, 2022 05:49
@zhuangchong zhuangchong modified the milestones: 3.0.1, 3.0.2 Sep 19, 2022
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 13, 2022
EricGao888 pushed a commit to EricGao888/dolphinscheduler that referenced this pull request Nov 5, 2022
EricGao888 added a commit that referenced this pull request Nov 5, 2022
Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants