Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-25][Remote Logging] Split remote logging configuration #15826

Merged
merged 2 commits into from
May 6, 2024

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Apr 10, 2024

Purpose of the pull request

resolve: #15774

Brief change log

image

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@SbloodyS SbloodyS added feature new feature 3.3.0 labels Apr 11, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Apr 11, 2024
@pegasas pegasas force-pushed the issues/15774 branch 5 times, most recently from 9ad1799 to 1f20762 Compare April 14, 2024 12:32
@pegasas pegasas marked this pull request as ready for review April 14, 2024 12:32
@pegasas pegasas force-pushed the issues/15774 branch 2 times, most recently from 26e86bb to 06561b8 Compare April 14, 2024 16:57
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should only need to add implementation ImmutablePriorityYamlDelegate and ImmutableYamlDelegate

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 39.81%. Comparing base (fa6ea8b) to head (0a143a4).

❗ Current head 0a143a4 differs from pull request most recent head 2dcdddf. Consider uploading reports for the commit 2dcdddf to get more accurate results

Files Patch % Lines
...scheduler/common/config/ImmutableYamlDelegate.java 61.53% 10 Missing ⚠️
...mmon/config/ImmutablePriorityPropertyDelegate.java 81.25% 3 Missing ⚠️
...duler/common/config/ImmutablePropertyDelegate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15826      +/-   ##
============================================
- Coverage     39.89%   39.81%   -0.08%     
+ Complexity     5057     5038      -19     
============================================
  Files          1353     1354       +1     
  Lines         45621    45659      +38     
  Branches       4891     4894       +3     
============================================
- Hits          18199    18181      -18     
- Misses        25516    25572      +56     
  Partials       1906     1906              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented May 6, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
16.1% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@rickchengx rickchengx merged commit d218b02 into apache:dev May 6, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSIP-25][Remote Logging] Split remote logging configuration
5 participants