Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sudo enable is false will still check tenant exist #16071

Merged
merged 1 commit into from
May 27, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 26, 2024

Purpose of the pull request

When we set sudo.enable=false, then ds will not use tenant, but will still check tenant exist.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2024

Codecov Report

Attention: Patch coverage is 20.83333% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 40.66%. Comparing base (fb9172c) to head (3556d4f).

Current head 3556d4f differs from pull request most recent head e6efed5

Please upload reports for the commit e6efed5 to get more accurate results.

Files Patch % Lines
...phinscheduler/server/worker/utils/TenantUtils.java 22.72% 16 Missing and 1 partial ⚠️
...hinscheduler/common/constants/TenantConstants.java 0.00% 1 Missing ⚠️
...duler/server/worker/runner/WorkerTaskExecutor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16071      +/-   ##
============================================
- Coverage     40.66%   40.66%   -0.01%     
- Complexity     5225     5227       +2     
============================================
  Files          1380     1381       +1     
  Lines         46009    46010       +1     
  Branches       4919     4920       +1     
============================================
- Hits          18709    18708       -1     
- Misses        25376    25377       +1     
- Partials       1924     1925       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.6% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit af55f94 into apache:dev May 27, 2024
62 of 63 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixTenantCheck branch May 27, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants