Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] ensure number type field has number type value when edting alarm instance #16089

Merged
merged 1 commit into from
May 30, 2024

Conversation

rockfang
Copy link
Contributor

Purpose of the pull request

to close #16084

Brief change log

ensure number type field has number type value

Verify this pull request

image

@github-actions github-actions bot added the UI ui and front end related label May 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.67%. Comparing base (a724518) to head (aa5618c).

Current head aa5618c differs from pull request most recent head 4429896

Please upload reports for the commit 4429896 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16089      +/-   ##
============================================
- Coverage     40.67%   40.67%   -0.01%     
+ Complexity     5238     5237       -1     
============================================
  Files          1382     1382              
  Lines         46023    46023              
  Branches       4922     4922              
============================================
- Hits          18719    18718       -1     
  Misses        25379    25379              
- Partials       1925     1926       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@SbloodyS SbloodyS merged commit ac1eaca into apache:dev May 30, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [AlertInstance Manage] verification exception when editing alarm instance
4 participants