Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Improvement] Abnormal characters check" #16102

Merged
merged 1 commit into from
May 31, 2024
Merged

Revert "[Improvement] Abnormal characters check" #16102

merged 1 commit into from
May 31, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 31, 2024 •
edited
Loading

Since this pr make the resource center doesn't work, due to the check method is incorrect.

The file path will have prefix e.g. "hdfs://", 'file://'

close #16006

@ruanwenjun ruanwenjun self-assigned this May 31, 2024
caishunfeng
caishunfeng approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng
Copy link
Contributor

davidzollo
davidzollo approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@davidzollo davidzollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@SbloodyS SbloodyS merged commit 7ae9ca5 into dev May 31, 2024
63 checks passed
@SbloodyS SbloodyS added the 3.2.2 label May 31, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone May 31, 2024
@SbloodyS SbloodyS added the bug Something isn't working label May 31, 2024
@SbloodyS SbloodyS deleted the revert-15824-dev branch May 31, 2024 13:14
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request May 31, 2024
@ruanwenjun
Revert "[Improvement] Abnormal characters check (apache#15824)" (apac…
338e9b2 
…he#16102)

This reverts commit e5e7749.

(cherry picked from commit 7ae9ca5)
SbloodyS pushed a commit that referenced this pull request May 31, 2024
@ruanwenjun
Revert "[Improvement] Abnormal characters check (#15824)" (#16102) (#…
72b4024 
…16103)

This reverts commit e5e7749.

(cherry picked from commit 7ae9ca5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caishunfeng caishunfeng caishunfeng approved these changes

@davidzollo davidzollo davidzollo approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@ruanwenjun ruanwenjun

Labels
3.2.2 backend bug Something isn't working priority:high
Projects
None yet
Milestone
3.2.2
Development

Successfully merging this pull request may close these issues.

[Bug] [Resource] unable to access file in resource center
4 participants
@ruanwenjun @caishunfeng @davidzollo @SbloodyS