Skip to content

[deploy] Make install.sh as executable script#7862

Merged
zhongjiajie merged 2 commits into
apache:devfrom
zhongjiajie:dp-exe-install
Jan 7, 2022
Merged

[deploy] Make install.sh as executable script#7862
zhongjiajie merged 2 commits into
apache:devfrom
zhongjiajie:dp-exe-install

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Jan 6, 2022

When I build dev branch and find our script install.sh is not executable script, I have to run commend chmod a+x install.sh before run it

After this patch, script permission like that
image

fix: #7860

@zhongjiajie zhongjiajie self-assigned this Jan 6, 2022
@zhongjiajie zhongjiajie added the minor Chore Chores about the project, like code clean, typo, etc. label Jan 6, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 6, 2022

Codecov Report

Merging #7862 (c35ece5) into dev (7fd94ff) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev    #7862   +/-   ##
=========================================
  Coverage     41.03%   41.03%           
- Complexity     3695     3696    +1     
=========================================
  Files           637      637           
  Lines         27025    27025           
  Branches       3063     3063           
=========================================
+ Hits          11089    11090    +1     
  Misses        14867    14867           
+ Partials       1069     1068    -1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd94ff...c35ece5. Read the comment docs.

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend setting file permissions when using maven to build package

For example like this:

        <fileSet>
            <directory>${basedir}/../script</directory>
            <outputDirectory>bin</outputDirectory>
            <fileMode>0755</fileMode>
            <directoryMode>0755</directoryMode>
        </fileSet>

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Jan 7, 2022

I test locally, it is success although I revert commit 86deec8. So I think it is ready to go now.
BTW, I perfer to keep commit 86deec8 to ensure it work when user copy-paste form our source code
image

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Contributor

@zhuangchong zhuangchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zhongjiajie zhongjiajie merged commit 62cac2d into apache:dev Jan 7, 2022
@zhongjiajie zhongjiajie deleted the dp-exe-install branch January 7, 2022 05:24
@zhongjiajie
Copy link
Copy Markdown
Member Author

Thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Chore Chores about the project, like code clean, typo, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [deploy] Shell script install.sh in not executable

3 participants