[deploy] Make install.sh as executable script#7862
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #7862 +/- ##
=========================================
Coverage 41.03% 41.03%
- Complexity 3695 3696 +1
=========================================
Files 637 637
Lines 27025 27025
Branches 3063 3063
=========================================
+ Hits 11089 11090 +1
Misses 14867 14867
+ Partials 1069 1068 -1
Continue to review full report at Codecov.
|
zhuangchong
reviewed
Jan 7, 2022
Contributor
zhuangchong
left a comment
There was a problem hiding this comment.
I recommend setting file permissions when using maven to build package
For example like this:
<fileSet>
<directory>${basedir}/../script</directory>
<outputDirectory>bin</outputDirectory>
<fileMode>0755</fileMode>
<directoryMode>0755</directoryMode>
</fileSet>
Member
Author
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
Thanks for reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.









When I build dev branch and find our script install.sh is not executable script, I have to run commend chmod a+x install.sh before run it
After this patch, script permission like that

fix: #7860