Skip to content

[Feature][UI Next] Add custom parameters to form#8271

Merged
zhongjiajie merged 1 commit into
apache:devfrom
Amy0104:form-customParameters
Jan 31, 2022
Merged

[Feature][UI Next] Add custom parameters to form#8271
zhongjiajie merged 1 commit into
apache:devfrom
Amy0104:form-customParameters

Conversation

@Amy0104
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 commented Jan 31, 2022

Purpose of the pull request

This pull request adds custom parameters to form

Brief change log

  • Form Component - Custom Parameters

Releated issues

#7928

Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 31, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.15%. Comparing base (63f7efa) to head (c373f49).
⚠️ Report is 3029 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #8271      +/-   ##
============================================
- Coverage     45.15%   45.15%   -0.01%     
+ Complexity     3981     3980       -1     
============================================
  Files           678      678              
  Lines         26343    26343              
  Branches       2836     2836              
============================================
- Hits          11895    11894       -1     
  Misses        13328    13328              
- Partials       1120     1121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongjiajie zhongjiajie merged commit 6be2201 into apache:dev Jan 31, 2022
@Amy0104 Amy0104 deleted the form-customParameters branch March 10, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants