[Fix-8389][Common] Fix oshi compatibility issues cause it fail to boot on m1 mac#8390
Merged
Conversation
zhongjiajie
reviewed
Feb 15, 2022
Codecov Report
@@ Coverage Diff @@
## dev #8390 +/- ##
============================================
- Coverage 45.36% 45.35% -0.02%
- Complexity 3993 4026 +33
============================================
Files 680 686 +6
Lines 26417 26709 +292
Branches 2839 2868 +29
============================================
+ Hits 11985 12114 +129
- Misses 13299 13450 +151
- Partials 1133 1145 +12
Continue to review full report at Codecov.
|
lenboo
reviewed
Feb 15, 2022
Member
|
@ronyang1985 Is it ready to go now? |
Contributor
Author
|
@zhongjiajie |
|
SonarCloud Quality Gate failed. |
Member
|
Thanks @ruanwenjun reviewing, I am not sure about the License PTAL @CalvinKirs |
Member
|
If the License is good, we could merge to it |
zhongjiajie
approved these changes
Feb 21, 2022
Member
zhongjiajie
left a comment
There was a problem hiding this comment.
LGTM, thanks @ronyang1985
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Purpose of the pull request
fix #8389