Skip to content

[Fix-8389][Common] Fix oshi compatibility issues cause it fail to boot on m1 mac#8390

Merged
zhongjiajie merged 8 commits into
apache:devfrom
ronyang1985:fixbug-8389
Feb 21, 2022
Merged

[Fix-8389][Common] Fix oshi compatibility issues cause it fail to boot on m1 mac#8390
zhongjiajie merged 8 commits into
apache:devfrom
ronyang1985:fixbug-8389

Conversation

@ronyang1985
Copy link
Copy Markdown
Contributor

Purpose of the pull request

fix #8389

@zhongjiajie zhongjiajie added bug Something isn't working first time contributor First-time contributor labels Feb 15, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #8390 (55684f4) into dev (68ad22b) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8390      +/-   ##
============================================
- Coverage     45.36%   45.35%   -0.02%     
- Complexity     3993     4026      +33     
============================================
  Files           680      686       +6     
  Lines         26417    26709     +292     
  Branches       2839     2868      +29     
============================================
+ Hits          11985    12114     +129     
- Misses        13299    13450     +151     
- Partials       1133     1145      +12     
Impacted Files Coverage Δ
.../apache/dolphinscheduler/common/utils/OSUtils.java 17.21% <77.77%> (+3.32%) ⬆️
...r/service/queue/PeerTaskInstancePriorityQueue.java 68.00% <0.00%> (-5.92%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.12%) ⬇️
...er/api/service/impl/TaskDefinitionServiceImpl.java 23.18% <0.00%> (-0.12%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <0.00%> (ø)
...dolphinscheduler/service/k8s/K8sClientService.java 0.00% <0.00%> (ø)
...uler/api/service/impl/K8sNameSpaceServiceImpl.java 78.90% <0.00%> (ø)
...va/org/apache/dolphinscheduler/dao/entity/K8s.java 0.00% <0.00%> (ø)
...ache/dolphinscheduler/dao/entity/K8sNamespace.java 0.00% <0.00%> (ø)
...heduler/api/controller/K8sNamespaceController.java 71.42% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ad22b...55684f4. Read the comment docs.

Comment thread pom.xml
@zhongjiajie
Copy link
Copy Markdown
Member

@ronyang1985 Is it ready to go now?

@ronyang1985
Copy link
Copy Markdown
Contributor Author

@zhongjiajie
I made some change, and sleep is not required now.
Let's continue

Copy link
Copy Markdown
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

30.3% 30.3% Coverage
4.2% 4.2% Duplication

@zhongjiajie
Copy link
Copy Markdown
Member

Thanks @ruanwenjun reviewing, I am not sure about the License PTAL @CalvinKirs

@zhongjiajie
Copy link
Copy Markdown
Member

If the License is good, we could merge to it

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. License good.

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ronyang1985

@zhongjiajie zhongjiajie merged commit 83e88c4 into apache:dev Feb 21, 2022
@brave-lee brave-lee added this to the 2.0.6-release milestone Apr 16, 2022
@brave-lee brave-lee removed this from the 2.0.6 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-arm64 bug Something isn't working first time contributor First-time contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [common] oshi compatibility issues cause it fail to boot on m1 mac

7 participants