Skip to content

[Docs][UI Next] Add package license.#8545

Merged
zhongjiajie merged 2 commits into
apache:devfrom
songjianet:docs-license-package
Feb 26, 2022
Merged

[Docs][UI Next] Add package license.#8545
zhongjiajie merged 2 commits into
apache:devfrom
songjianet:docs-license-package

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

#7332

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added dependencies Pull requests that update a dependency file document labels Feb 25, 2022
@songjianet songjianet self-assigned this Feb 25, 2022
@songjianet songjianet changed the title [Docs][UI-Next] Add package license. [Docs][UI Next] Add package license. Feb 25, 2022
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie
Copy link
Copy Markdown
Member

Should we also add to License file? @CalvinKirs

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need license to dolphinscheduler-dist/release-docs/LICENSE
and add NOTICE to dolphinscheduler-dist/release-docs/NOTICE
In addition, please make sure that the corresponding license corresponds to the version you are referencing

@songjianet
Copy link
Copy Markdown
Member Author

you also need license to dolphinscheduler-dist/release-docs/LICENSE and add NOTICE to dolphinscheduler-dist/release-docs/NOTICE In addition, please make sure that the corresponding license corresponds to the version you are referencing

I know I have to deal with this, but I'm working on other things now, I can merge these first, and I'll add them later.

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhongjiajie zhongjiajie merged commit 8ed2eeb into apache:dev Feb 26, 2022
@songjianet songjianet deleted the docs-license-package branch February 27, 2022 01:13
@@ -0,0 +1,19 @@
Copyright OpenJS Foundation and other contributors, <www.openjsf.org>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies in devDependencies don't need to be included in the release licenses

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece may be adjusted in the future, so I wrote all the dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file document

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants