Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fix build standalone error.#8590

Merged
zhongjiajie merged 1 commit into
apache:devfrom
songjianet:fix-build-standalone-error
Mar 1, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fix build standalone error.#8590
zhongjiajie merged 1 commit into
apache:devfrom
songjianet:fix-build-standalone-error

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

#8508

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet self-assigned this Mar 1, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 1, 2022
@songjianet songjianet changed the title [Fix][UI Next] Fix build standalone error. [Fix][UI Next][V1.0.0-Alpha] Fix build standalone error. Mar 1, 2022
Copy link
Copy Markdown
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zhongjiajie zhongjiajie merged commit f2c6fbb into apache:dev Mar 1, 2022
@zhongjiajie
Copy link
Copy Markdown
Member

@songjianet Does this PR fix #8580? If so we should close issue #8580

@songjianet
Copy link
Copy Markdown
Member Author

@songjianet Does this PR fix #8580? If so we should close issue #8580

no need to close.

@songjianet songjianet deleted the fix-build-standalone-error branch March 1, 2022 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants