Skip to content

[CI] Require E2E to passed before merging#8891

Merged
CalvinKirs merged 1 commit into
devfrom
required-e2e-passed
Mar 15, 2022
Merged

[CI] Require E2E to passed before merging#8891
CalvinKirs merged 1 commit into
devfrom
required-e2e-passed

Conversation

@kezhenxu94
Copy link
Copy Markdown
Member

No description provided.

@kezhenxu94 kezhenxu94 force-pushed the required-e2e-passed branch from 3650636 to 9232751 Compare March 15, 2022 02:48
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #8891 (f0b7ca7) into dev (7433dd2) will decrease coverage by 0.08%.
The diff coverage is 50.60%.

❗ Current head f0b7ca7 differs from pull request most recent head a3f2af7. Consider uploading reports for the commit a3f2af7 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8891      +/-   ##
============================================
- Coverage     45.36%   45.28%   -0.09%     
+ Complexity     4084     4080       -4     
============================================
  Files           702      702              
  Lines         27113    27177      +64     
  Branches       2897     2907      +10     
============================================
+ Hits          12301    12308       +7     
- Misses        13657    13706      +49     
- Partials       1155     1163       +8     
Impacted Files Coverage Δ
...heduler/api/service/impl/SchedulerServiceImpl.java 8.36% <0.00%> (-0.27%) ⬇️
...che/dolphinscheduler/common/enums/WarningType.java 0.00% <0.00%> (ø)
...org/apache/dolphinscheduler/alert/AlertSender.java 74.03% <42.85%> (-14.43%) ⬇️
...java/org/apache/dolphinscheduler/dao/AlertDao.java 22.47% <50.00%> (+0.63%) ⬆️
.../org/apache/dolphinscheduler/dao/entity/Alert.java 46.26% <50.00%> (+0.36%) ⬆️
...inscheduler/service/alert/ProcessAlertManager.java 44.84% <50.00%> (+0.05%) ⬆️
.../remote/command/alert/AlertSendRequestCommand.java 92.00% <60.00%> (-8.00%) ⬇️
...hinscheduler/service/alert/AlertClientService.java 66.66% <66.66%> (ø)
...che/dolphinscheduler/alert/AlertPluginManager.java 93.75% <100.00%> (+2.84%) ⬆️
.../dolphinscheduler/alert/AlertRequestProcessor.java 93.33% <100.00%> (+0.47%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7433dd2...a3f2af7. Read the comment docs.

@kezhenxu94 kezhenxu94 force-pushed the required-e2e-passed branch 2 times, most recently from 37991ce to a3f2af7 Compare March 15, 2022 03:22
@kezhenxu94 kezhenxu94 force-pushed the required-e2e-passed branch from a3f2af7 to 8201290 Compare March 15, 2022 04:03
@kezhenxu94 kezhenxu94 requested a review from songjianet March 15, 2022 04:03
@kezhenxu94 kezhenxu94 marked this pull request as ready for review March 15, 2022 04:03
@kezhenxu94
Copy link
Copy Markdown
Member Author

FYI @SbloodyS

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Copy Markdown
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs CalvinKirs merged commit 14bb722 into dev Mar 15, 2022
@kezhenxu94 kezhenxu94 deleted the required-e2e-passed branch March 15, 2022 06:48
@zhongjiajie
Copy link
Copy Markdown
Member

Well done~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants