Skip to content

[Fix-8836][UI Next][V1.0.0-Alpha] Rectify this issue about creating a file or directory with a wrong path. #8892

Merged
songjianet merged 7 commits into
apache:devfrom
calvinjiang:f-file-manage
Mar 15, 2022
Merged

[Fix-8836][UI Next][V1.0.0-Alpha] Rectify this issue about creating a file or directory with a wrong path. #8892
songjianet merged 7 commits into
apache:devfrom
calvinjiang:f-file-manage

Conversation

@calvinjiang
Copy link
Copy Markdown
Contributor

Purpose of the pull request

This PR will close #8836 .

Brief change log

Verify this pull request

This change added tests and can be verified as follows:

  • Manually verified the change by testing locally.
    The test results are as follows:

image

image

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8892 (a0ff15f) into dev (db64dca) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8892      +/-   ##
============================================
- Coverage     45.30%   45.27%   -0.03%     
+ Complexity     4082     4081       -1     
============================================
  Files           702      702              
  Lines         27177    27186       +9     
  Branches       2907     2908       +1     
============================================
- Hits          12312    12309       -3     
- Misses        13704    13715      +11     
- Partials       1161     1162       +1     
Impacted Files Coverage Δ
...nscheduler/api/controller/ResourcesController.java 57.89% <0.00%> (-1.04%) ⬇️
...heduler/api/service/impl/ResourcesServiceImpl.java 53.66% <0.00%> (-0.68%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 83.60% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db64dca...a0ff15f. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit c7e80e4 into apache:dev Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][UI Next][V1.0.0-Alpha] create directory/file path wrong

3 participants