Skip to content

[Bug-8810] [master] add try catch to onSuccess method in the WorkflowExecuteThreadPool#8896

Merged
caishunfeng merged 1 commit into
apache:devfrom
guoshupei:Bug-8810
Mar 15, 2022
Merged

[Bug-8810] [master] add try catch to onSuccess method in the WorkflowExecuteThreadPool#8896
caishunfeng merged 1 commit into
apache:devfrom
guoshupei:Bug-8810

Conversation

@guoshupei
Copy link
Copy Markdown
Contributor

@guoshupei guoshupei commented Mar 15, 2022

This closes #8810

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@caishunfeng caishunfeng changed the title [Bug-8810] [master] add try catch to onSuccess method in the Workflow… [Bug-8810] [master] add try catch to onSuccess method in the WorkflowExecuteThreadPool Mar 15, 2022
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8896 (c99fbea) into dev (c7e80e4) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8896      +/-   ##
============================================
- Coverage     45.29%   45.27%   -0.02%     
+ Complexity     4083     4081       -2     
============================================
  Files           702      702              
  Lines         27186    27186              
  Branches       2908     2908              
============================================
- Hits          12313    12309       -4     
- Misses        13713    13715       +2     
- Partials       1160     1162       +2     
Impacted Files Coverage Δ
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7e80e4...c99fbea. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@caishunfeng caishunfeng merged commit 3114c91 into apache:dev Mar 15, 2022
@guoshupei guoshupei deleted the Bug-8810 branch March 15, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Process Instance state does not change correctly and may cause Memory Leak

3 participants