Skip to content

[python] Add autoflake to auto rm unused import#8897

Merged
caishunfeng merged 1 commit into
apache:devfrom
zhongjiajie:ci-add-rm-unused
Mar 16, 2022
Merged

[python] Add autoflake to auto rm unused import#8897
caishunfeng merged 1 commit into
apache:devfrom
zhongjiajie:ci-add-rm-unused

Conversation

@zhongjiajie
Copy link
Copy Markdown
Member

@zhongjiajie zhongjiajie commented Mar 15, 2022

  • Add a new commit hook to pre-commit, to auto
    remove unused imports
  • Remove all unused pass statements
  • Add autoflake to tox and out CI

close: #8592

@zhongjiajie
[python] Add autoflake to auto rm unused import
b742faf 
* Add a new commit hook to pre-commit, to auto
  remove unused imports
* Remove all unused pass statements
* Add autoflake to tox and out CI

close: apache#8592
@zhongjiajie zhongjiajie self-assigned this Mar 15, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 15, 2022 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.27%. Comparing base (db64dca) to head (b742faf).
⚠️ Report is 2782 commits behind head on dev.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8897      +/-   ##
============================================
- Coverage     45.30%   45.27%   -0.03%     
+ Complexity     4082     4081       -1     
============================================
  Files           702      702              
  Lines         27177    27186       +9     
  Branches       2907     2908       +1     
============================================
- Hits          12312    12309       -3     
- Misses        13704    13715      +11     
- Partials       1161     1162       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Mar 15, 2022 •
edited
Loading

PTAL @devosend @jieguangzhou

devosend
devosend approved these changes Mar 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caishunfeng
caishunfeng approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@caishunfeng caishunfeng merged commit e53ac4e into apache:dev Mar 16, 2022
@zhongjiajie zhongjiajie deleted the ci-add-rm-unused branch March 16, 2022 01:50
@zhongjiajie
Copy link
Copy Markdown
Member Author

zhongjiajie commented Mar 16, 2022

Thanks for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devosend devosend devosend approved these changes

@caishunfeng caishunfeng caishunfeng approved these changes

@songjianet songjianet Awaiting requested review from songjianet

Assignees

@zhongjiajie zhongjiajie

Labels

CI&CD enhancement New feature or request Pyscheduler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature][python] Add CI auto remove unused package

4 participants

@zhongjiajie @codecov-commenter @devosend @caishunfeng