Skip to content

[Feature-8530][API] add system default timezone if no user timezone when get userInfo#8899

Merged
songjianet merged 1 commit into
apache:devfrom
caishunfeng:default_timezone
Mar 15, 2022
Merged

[Feature-8530][API] add system default timezone if no user timezone when get userInfo#8899
songjianet merged 1 commit into
apache:devfrom
caishunfeng:default_timezone

Conversation

@caishunfeng
Copy link
Copy Markdown
Contributor

issue: #8530

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@caishunfeng caishunfeng changed the title [Feature-8530][API] add system default timezone if no user timezone [Feature-8530][API] add system default timezone if no user timezone when get userInfo Mar 15, 2022
@caishunfeng
Copy link
Copy Markdown
Contributor Author

PTAL @devosend @songjianet

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #8899 (c92f01c) into dev (db64dca) will decrease coverage by 5.52%.
The diff coverage is 27.30%.

❗ Current head c92f01c differs from pull request most recent head 18ba3c0. Consider uploading reports for the commit 18ba3c0 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #8899      +/-   ##
============================================
- Coverage     45.30%   39.77%   -5.53%     
- Complexity     4082     4262     +180     
============================================
  Files           702      808     +106     
  Lines         27177    32544    +5367     
  Branches       2907     3647     +740     
============================================
+ Hits          12312    12946     +634     
- Misses        13704    18372    +4668     
- Partials       1161     1226      +65     
Impacted Files Coverage Δ
...cheduler/api/controller/AccessTokenController.java 88.23% <ø> (ø)
...uler/api/controller/ProcessInstanceController.java 72.09% <ø> (ø)
.../api/controller/ProcessTaskRelationController.java 21.42% <ø> (ø)
...hinscheduler/api/controller/ProjectController.java 68.00% <ø> (ø)
...nscheduler/api/controller/ResourcesController.java 57.89% <0.00%> (-1.04%) ⬇️
...duler/api/controller/TaskDefinitionController.java 3.22% <ø> (ø)
...nscheduler/api/controller/TaskGroupController.java 81.81% <ø> (ø)
...heduler/api/controller/TaskInstanceController.java 55.55% <ø> (ø)
...inscheduler/api/controller/UiPluginController.java 100.00% <ø> (ø)
...lphinscheduler/api/controller/UsersController.java 61.53% <ø> (ø)
... and 374 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db64dca...18ba3c0. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 60fbbcb into apache:dev Mar 15, 2022
@caishunfeng caishunfeng deleted the default_timezone branch March 15, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants