Skip to content

[Fix][UI Next][V1.0.0-Alpha] Fix the upstream Tasks field UI display extra long.#9148

Merged
calvinjiang merged 2 commits into
apache:devfrom
songjianet:fix-task-definition
Mar 24, 2022
Merged

[Fix][UI Next][V1.0.0-Alpha] Fix the upstream Tasks field UI display extra long.#9148
calvinjiang merged 2 commits into
apache:devfrom
songjianet:fix-task-definition

Conversation

@songjianet
Copy link
Copy Markdown
Member

Purpose of the pull request

close #9113

2ffd69d825d4dbc7a5893dc9ecad76e

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Mar 24, 2022
@songjianet songjianet self-assigned this Mar 24, 2022
Copy link
Copy Markdown
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #9148 (12ec2fa) into dev (73ca831) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9148      +/-   ##
============================================
- Coverage     40.32%   40.28%   -0.04%     
+ Complexity     4370     4367       -3     
============================================
  Files           808      808              
  Lines         32569    32569              
  Branches       3650     3650              
============================================
- Hits          13135    13122      -13     
- Misses        18205    18220      +15     
+ Partials       1229     1227       -2     
Impacted Files Coverage Δ
...er/master/processor/queue/TaskResponseService.java 49.43% <0.00%> (-13.49%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 56.33% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ca831...12ec2fa. Read the comment docs.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@calvinjiang calvinjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinjiang calvinjiang merged commit 647b099 into apache:dev Mar 24, 2022
@songjianet songjianet deleted the fix-task-definition branch March 24, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working UI ui and front end related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug-FE][UI Next][V1.0.0-Alpha] Upstream Tasks field UI display extra long

4 participants