Skip to content
Permalink
Browse files
[fix](storage) fix core for string predicate in storage layer (#9500)

Co-authored-by: Wang Bo <wangbo36@meituan.com>
  • Loading branch information
wangbo and Wang Bo committed May 12, 2022
1 parent 4cd579b commit a0b95d8fcb29ae8d9f7754824725b3bdbabcb2ac
Showing 1 changed file with 22 additions and 2 deletions.
@@ -230,17 +230,35 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
void insert_many_binary_data(char* data_array, uint32_t* len_array,
uint32_t* start_offset_array, size_t num) override {
if constexpr (std::is_same_v<T, StringValue>) {
if (_pool == nullptr) {
_pool.reset(new MemPool("PredicateStringColumn"));
}

size_t total_mem_size = 0;
for (size_t i = 0; i < num; i++) {
total_mem_size += len_array[i];
}

char* destination = (char*)_pool->allocate(total_mem_size);
for (size_t i = 0; i < num; i++) {
uint32_t len = len_array[i];
uint32_t start_offset = start_offset_array[i];
insert_string_value(data_array + start_offset, len);
memcpy(destination, data_array + start_offset, len);
StringValue sv(destination, len);
data.push_back_without_reserve(sv);
destination += len;
}
}
}

void insert_default() override { data.push_back(T()); }

void clear() override { data.clear(); }
void clear() override {
data.clear();
if (_pool != nullptr) {
_pool->clear();
}
}

size_t byte_size() const override { return data.size() * sizeof(T); }

@@ -410,6 +428,8 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<

private:
Container data;
// manages the memory for slice's data(For string type)
std::unique_ptr<MemPool> _pool;
};
using ColumnStringValue = PredicateColumnType<StringValue>;

0 comments on commit a0b95d8

Please sign in to comment.