From bee5a854bfba5771279aaa3bfd674d0eeb3fd5ad Mon Sep 17 00:00:00 2001
From: morningman <morningman@163.com>
Date: Thu, 22 Sep 2022 11:39:28 +0800
Subject: [PATCH] 1

---
 .../src/main/java/org/apache/doris/analysis/AnalyticExpr.java | 1 +
 .../main/java/org/apache/doris/analysis/DefaultValueExpr.java | 2 +-
 .../main/java/org/apache/doris/analysis/EncryptKeyRef.java    | 2 +-
 .../main/java/org/apache/doris/analysis/ExistsPredicate.java  | 2 +-
 .../src/main/java/org/apache/doris/analysis/MaxLiteral.java   | 1 +
 .../src/main/java/org/apache/doris/analysis/Subquery.java     | 4 +++-
 6 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java
index 36895d81118ffb..c4d795a9c7024e 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java
@@ -201,6 +201,7 @@ public String debugString() {
 
     @Override
     protected void toThrift(TExprNode msg) {
+        throw new RuntimeException("AnalyticExpr should be rewritten");
     }
 
     public static boolean isAnalyticFn(Function fn) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/DefaultValueExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/DefaultValueExpr.java
index 01ed882a2cb888..5369db0d660485 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/DefaultValueExpr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/DefaultValueExpr.java
@@ -33,7 +33,7 @@ protected String toSqlImpl() {
 
     @Override
     protected void toThrift(TExprNode msg) {
-
+        throw new RuntimeException("DefaultValueExpr should be rewritten");
     }
 
     @Override
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/EncryptKeyRef.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/EncryptKeyRef.java
index 9a01b065f48c9a..7416311ad97ee9 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/EncryptKeyRef.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/EncryptKeyRef.java
@@ -89,7 +89,7 @@ protected String toSqlImpl() {
 
     @Override
     protected void toThrift(TExprNode msg) {
-        // no operation
+        throw new RuntimeException("EncryptKeyRef should be rewritten");
     }
 
     @Override
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExistsPredicate.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExistsPredicate.java
index b061b19e2f47a9..985dd14b05023d 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExistsPredicate.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExistsPredicate.java
@@ -53,7 +53,7 @@ public Expr negate() {
     @Override
     protected void toThrift(TExprNode msg) {
         // Cannot serialize a nested predicate
-        Preconditions.checkState(false);
+        throw new RuntimeException("ExistsPredicate should be rewritten");
     }
 
     @Override
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/MaxLiteral.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/MaxLiteral.java
index 783ad888235fc3..2b344d95edc85f 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/MaxLiteral.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/MaxLiteral.java
@@ -50,6 +50,7 @@ public int compareLiteral(LiteralExpr expr) {
 
     @Override
     protected void toThrift(TExprNode msg) {
+        throw new RuntimeException("MaxLiteral should be rewritten");
     }
 
     @Override
diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/Subquery.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/Subquery.java
index 4246edb5e44296..e141bb5ed5c219 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/Subquery.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/Subquery.java
@@ -220,5 +220,7 @@ public Expr reset() {
     }
 
     @Override
-    protected void toThrift(TExprNode msg) {}
+    protected void toThrift(TExprNode msg) {
+        throw new RuntimeException("Subquery should be rewritten");
+    }
 }