[pipelineX](fix) Fix coredump if prepare failed#30250
Merged
Merged
Conversation
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| virtual Status close(RuntimeState* state, Status exec_status) { | ||
| return state->get_sink_local_state(operator_id())->close(state, exec_status); | ||
| Status close(RuntimeState* state, Status exec_status) { |
Contributor
There was a problem hiding this comment.
warning: method 'close' can be made const [readability-make-member-function-const]
Suggested change
| Status close(RuntimeState* state, Status exec_status) { | |
| Status close(RuntimeState* state, Status exec_status) const { |
TPC-H: Total hot run time: 38862 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 176834 ms |
ClickBench: Total hot run time: 30.4 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
BiteTheDDDDt
approved these changes
Jan 23, 2024
zhangstar333
approved these changes
Jan 23, 2024
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Jan 24, 2024
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...