[fix](scan) Fix incorrect query results due to data race of compaction and parallel scanners building#40552
Merged
dataroaring merged 1 commit intoSep 11, 2024
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38308 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 187496 ms |
ClickBench: Total hot run time: 31.64 s |
Hastyshell
force-pushed
the
fix-parallel-scanner-builder-datarace
branch
2 times, most recently
from
99a846f to
94ddbc4
Compare
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38036 ms |
TPC-DS: Total hot run time: 192267 ms |
ClickBench: Total hot run time: 31.22 s |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
…and parallel scanners building
Hastyshell
force-pushed
the
fix-parallel-scanner-builder-datarace
branch
from
94ddbc4 to
a200125
Compare
Collaborator
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38229 ms |
TPC-DS: Total hot run time: 198196 ms |
ClickBench: Total hot run time: 31.83 s |
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Sep 13, 2024
…n and parallel scanners building (apache#40552) Capture rowset splits and delete predicates atomicly in `ParallelScannerBuilder::_load` as a single read source. In this way, we could prevent reading stale rowsets with the delete predicates eliminated by (base) compaction.
dataroaring
pushed a commit
that referenced
this pull request
Sep 14, 2024
…n and parallel scanners building (#40552) ## Proposed changes Capture rowset splits and delete predicates atomicly in `ParallelScannerBuilder::_load` as a single read source. In this way, we could prevent reading stale rowsets with the delete predicates eliminated by (base) compaction.
HappenLee
pushed a commit
to HappenLee/incubator-doris
that referenced
this pull request
Apr 24, 2026
…n and parallel scanners building (apache#40552) ## Proposed changes Capture rowset splits and delete predicates atomicly in `ParallelScannerBuilder::_load` as a single read source. In this way, we could prevent reading stale rowsets with the delete predicates eliminated by (base) compaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Capture rowset splits and delete predicates atomicly in
ParallelScannerBuilder::_loadas a single read source.In this way, we could prevent reading stale rowsets with the delete predicates eliminated by (base) compaction.